-
Notifications
You must be signed in to change notification settings - Fork 2
Add support for multiplatform targets #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, cool to see the underlying library is now multiplatform.
Unfortunately I don't have a Mac handy that can build iOS+Mac artifacts to publish to maven central for non-android/JVM.
Feel free to set up GitHub actions to generate artifacts if you'd like to see another release cut.
I wish there was a better way of handling this problem, it's such a sore point in Kotlin multiplatform.
id("org.jetbrains.compose") version "1.6.11" | ||
id("com.android.library") version "8.2.0" | ||
kotlin("multiplatform") version "2.2.10" | ||
id("org.jetbrains.kotlin.plugin.compose") version "2.2.10" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious why the plugin is needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To use compose, it is now mandatory to apply this plugin: https://www.jetbrains.com/help/kotlin-multiplatform-dev/compose-compiler.html#migrating-a-compose-multiplatform-project
I have setup github actions. You'll need to set up the proper environment variables, then just publish a release on github and the workflow should start |
// - signing.gnupg.secretKeyRingFile | ||
// - mavenCentralUsername | ||
// - mavenCentralPassword | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not apply anymore now that the publishing happens via CI/CD
graphics-shapes is now multiplatform and this PR adds support for the missing multiplatform targets. Kotlin version and dependencies have been updated as well.